Skip to content

Fix regression in the listBackupSchedule API#12402

Merged
Pearl1594 merged 1 commit intoapache:4.22from
scclouds:fix-list-backup-schedules-regression
Jan 26, 2026
Merged

Fix regression in the listBackupSchedule API#12402
Pearl1594 merged 1 commit intoapache:4.22from
scclouds:fix-list-backup-schedules-regression

Conversation

@bernardodemarco
Copy link
Member

@bernardodemarco bernardodemarco commented Jan 9, 2026 •
edited
Loading

Description

PR #11587 changed the virtualmachineid parameter of the listBackupSchedule API to be optional. However, probably due to a conflict resolution, the change has been lost. As a consequence, the parameter is still required and when trying to access the view of backup schedules through the UI, an exception is thrown:

image

Therefore, this PR fixes this code regression.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@bernardodemarco bernardodemarco added this to the 4.22.1 milestone Jan 9, 2026
Pearl1594
Pearl1594 approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@Pearl1594
Copy link
Contributor

Pearl1594 commented Jan 9, 2026

@blueorangutan package

@codecov
Copy link

codecov bot commented Jan 9, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.59%. Comparing base (04875f1) to head (54cc6f8).
⚠️ Report is 49 commits behind head on 4.22.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.22   #12402      +/-   ##
============================================
- Coverage     17.59%   17.59%   -0.01%     
+ Complexity    15599    15597       -2     
============================================
  Files          5910     5910              
  Lines        529733   529733              
  Branches      64719    64719              
============================================
- Hits          93215    93208       -7     
- Misses       426025   426033       +8     
+ Partials      10493    10492       -1
Flag Coverage Δ
uitests 3.57% <ø> (ø)
unittests 18.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 12, 2026

@blueorangutan package

@blueorangutan
Copy link

blueorangutan commented Jan 12, 2026

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

blueorangutan commented Jan 12, 2026

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16330

sureshanaparti
sureshanaparti approved these changes Jan 12, 2026
View reviewed changes
Copy link
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 12, 2026

@blueorangutan test

@blueorangutan
Copy link

blueorangutan commented Jan 12, 2026

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link

blueorangutan commented Jan 13, 2026

[SF] Trillian test result (tid-15168)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54744 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12402-t15168-kvm-ol8.zip
Smoke tests completed. 148 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_03_deploy_and_scale_kubernetes_cluster Failure 38.01 test_kubernetes_clusters.py

vishesh92
vishesh92 approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@bernardodemarco
Copy link
Member Author

bernardodemarco commented Jan 26, 2026

@sureshanaparti @Pearl1594 @DaanHoogland can we merge this one? (only a regression fix)

DaanHoogland
DaanHoogland approved these changes Jan 26, 2026
View reviewed changes
Copy link
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 26, 2026

let me do a quick test @bernardodemarco , ...

@bernardodemarco
Copy link
Member Author

bernardodemarco commented Jan 26, 2026

let me do a quick test @bernardodemarco , ...

Sure, thanks!

@DaanHoogland
Copy link
Contributor

DaanHoogland commented Jan 26, 2026

couldn’t verify the regression but the fixed version works at least.

@Pearl1594
Copy link
Contributor

Pearl1594 commented Jan 26, 2026

@sureshanaparti @Pearl1594 @DaanHoogland can we merge this one? (only a regression fix)

I believe this is good to merge.

@Pearl1594 Pearl1594 merged commit 9b0c28c into apache:4.22 Jan 26, 2026
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

No one assigned

Labels

component:api

Projects

Apache CloudStack 4.22.1
Status: In Progress

Milestone

4.22.1

Development

Successfully merging this pull request may close these issues.

6 participants

@bernardodemarco @Pearl1594 @DaanHoogland @blueorangutan @vishesh92 @sureshanaparti